Bernhard Suttner
Bernhard Suttner
Nice PR for the 10.000 PR :-)
> Is this really correct? AmazonLinux has very different version numbers and the version number comparisons can be wrong. Can you add some data on any testing you've done? Don't...
The failed tests are not related. Any objections to get this change in @stejskalleos / @ekohl / @ofedoren ?
Can you use `Benchmark.measure` to determine which implementation is faster? It would also be interesting to run "EXPLAIN ANALYZE SELECT ....` on the DB to see which one is better.
Can you please update the snapshots @obol89 It should only be about these 2 files. Should be easys to update them manually on disk without recording the snapshots completely: https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.ubuntu4dhcp.snap.txt...
Ready to merge @ekohl ?
[test unit]
Failed tests are unrelated to this PR.