foreman icon indicating copy to clipboard operation
foreman copied to clipboard

Fixes #36847 - Rename initrd for Debian

Open obol89 opened this issue 2 years ago • 11 comments

initrd in official Debian repositories has .gz extension, not .img as it is in the template currently.

obol89 avatar Oct 20 '23 09:10 obol89

Can one of the admins verify this patch?

theforeman-bot avatar Oct 20 '23 09:10 theforeman-bot

Can one of the admins verify this patch?

theforeman-bot avatar Oct 20 '23 09:10 theforeman-bot

Can one of the admins verify this patch?

theforeman-bot avatar Oct 20 '23 09:10 theforeman-bot

ok to test

I've verified the URLs provided in https://projects.theforeman.org/issues/36847 so I think this is correct.

ekohl avatar Oct 20 '23 10:10 ekohl

Can you please update the snapshots @obol89

It should only be about these 2 files. Should be easys to update them manually on disk without recording the snapshots completely:

https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.ubuntu4dhcp.snap.txt https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.debian4dhcp.snap.txt

sbernhard avatar Dec 05 '23 13:12 sbernhard

Can you please update the snapshots @obol89

It should only be about these 2 files. Should be easys to update them manually on disk without recording the snapshots completely:

https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.ubuntu4dhcp.snap.txt https://github.com/theforeman/foreman/blob/develop/test/unit/foreman/renderer/snapshots/ProvisioningTemplate/iPXE/Preseed_default_iPXE.debian4dhcp.snap.txt

I just updated the files. I'm not sure if I did it correctly from the merge request / github perspective, but please let me know if there is anything else to do.

obol89 avatar Dec 14 '23 09:12 obol89

Ready to merge @ekohl ?

sbernhard avatar Dec 28 '23 08:12 sbernhard

Thank you for your contribution! This PR has been inactive for 3 months, closing for now. Feel free to reopen when you return to it. This is an automated process.

github-actions[bot] avatar Apr 10 '24 01:04 github-actions[bot]

I'm going to reopen this because I think it's still needed.

ekohl avatar Apr 26 '24 08:04 ekohl

[test]

sbernhard avatar May 10 '24 12:05 sbernhard

I opened https://github.com/theforeman/foreman/pull/10156 with https://github.com/theforeman/foreman/pull/9870#discussion_r1439551408 and resolved the merge conflicts.

ekohl avatar May 10 '24 13:05 ekohl