foreman icon indicating copy to clipboard operation
foreman copied to clipboard
verified publisher icon theforeman

Fixes #37090 - Add AmazonLinux to template metadata

Open m-bucher opened this issue 1 year ago • 3 comments

The current list of templates might not be complete :sweat_smile:

m-bucher avatar Jan 23 '24 16:01 m-bucher

Is this really correct? AmazonLinux has very different version numbers and the version number comparisons can be wrong. Can you add some data on any testing you've done?

Don't know exactly what you mean with "different version numbers"?

Currently, the name of Amazon is also used here: https://github.com/theforeman/foreman/blob/c75e2951cfc48ebeea1356765b52240be313dae4/app/services/katello/rhsm_fact_parser.rb#L166

sbernhard avatar Jan 24 '24 11:01 sbernhard

Don't know exactly what you mean with "different version numbers"?

The current AmazonLinux is 2023. If you look at the kickstart templates there are many comparisons against the OS major version that are based on the RHEL version numbers (just grep for major in app/views/unattended). Are any of those a problem?

ekohl avatar Jan 24 '24 16:01 ekohl