Bernhard Suttner

Results 189 comments of Bernhard Suttner

All checks have passed again. As said, if it works and there are not other, even better ideas to solve the really bad issue, I would vote to fix it...

> > Isn't this "more hackish" than have a well-documented flag with exactly this use-case? > > That's a fair question, perhaps it’s worth getting a third opinion on this....

how can we continue with this?

is it really necessary that a user is able to set the order? Personally, if not *really* necessary I would try to find a way, that the ordering is done...

Thanks @Thorben-D for your suggestion. Actually, I would prefer to have one Copy to Clipboard for all found issues. Would this be doable? Thoughts on this @MariaAga?

> Wouldn't it be better if we linked to the exact template that failed? We may need to restructure the errors for that but that would be better to debug....

> > Thanks @Thorben-D for your suggestion. Actually, I would prefer to have one Copy to Clipboard for all found issues. Would this be doable? > > Thoughts on this...

@MariaAga Can you have a look at this again and hopefully merge this then?

> Having said all of that, if you use global registration isn't it supposed to create an unmanaged host? I thought that's what this line is for: Well, the host...

Actually, this https://github.com/theforeman/foreman/pull/10246/files#diff-b7f82bd4fe3d5a5a8b246f502ab1e894197164cf7bf48fbfd5c2f3d76da2362eR564 already prevents that it reaches the section https://github.com/theforeman/foreman/pull/10246/files#diff-b7f82bd4fe3d5a5a8b246f502ab1e894197164cf7bf48fbfd5c2f3d76da2362eR570 which is necessary during host registration for a unmanaged host in the mentioned scenario. @ekohl Would do you prefer?...