Bernhard Suttner
Bernhard Suttner
> > Any opinions on cache removal/rewrite instead of patching it for one issue and leaving the other? > > We will need to dig deep into the history to...
Any feedback on this change @ShimShtein ?
Another try, similar to https://github.com/theforeman/foreman/pull/10529 to solve the firmware issue. This PR tries to solve the root cause of the issue, that the original firmware form value is changed while...
@nofaralfasi changed the name of the flag and changed it from additional function parameter to a attribute. This solved a lot of test issues. Additionally, I have added a comment....
Looks like the test issues in Katello are not related. E.g. https://github.com/theforeman/foreman/actions/runs/16202971385/job/45746456820?pr=10600 is failing because of the same issue.
> I feel that adding the `create_vm_ctx` variable in multiple places introduces unnecessary complexity and makes the code harder to follow and maintain. Is there a way we could simplify...
all tests have passed.
> Instead of introducing a new `create_vm_ctx` flag, have you considered using the `host_compute_attrs` method? It only passes a hash during actual VM creation from Foreman, so we might be...
> > Instead of introducing a new `create_vm_ctx` flag, have you considered using the `host_compute_attrs` method? It only passes a hash during actual VM creation from Foreman, so we might...
> > I had a look at the `host_compute_attrs` method. The only thing what would be possible is, to set the `create_mode`attribute in this method - but, actually to set...