Alexander Tsybulsky
Alexander Tsybulsky
- a point from @larshp against one-file-per-repo: potential commit conflicts. To be considered. Long texts in original xml/json: ``` doc: { ... line: { format: "U1", text: "&FUNCTIONALITY&" }, line:...
Maybe (maybe) it makes sense to leave `get_log` as `get_last_log`. E.g. `export_zip` command is performed in the router (and called from 2 places) and may have some log which should...
Yes, it would be better of course ... just not sure that it is always possible e.g. like in my example. A question: `ZCL_ABAPGIT_REPO_SRV->ZIF_ABAPGIT_REPO_SRV~PURGE` why do we need `refresh` on...
Looking at `ZCL_ABAPGIT_REPO_SRV->ZIF_ABAPGIT_REPO_SRV~PURGE` and `zcl_abapgit_objects=>delete` - the latter one collects exceptions for objects to the log. So in fact it builds it and is the only source of it. What...
Yes. But it can be transported differently. The top level code can receive it both as an exception and as a return param. Otherwise it has to catch exceptions and...
Done in #4590. One thing remaining is `repo->get_log`. Which is currently always uninitialized. Which should trigger "Last log" button in the toolbar. Which means that there should be some place...
For this particular case I have a suspect: the `ZCL_ABAPGIT_FILE_STATUS=>PROCESS_REMOTE` overwrites the status ```abap IF sy-subrc = 0 AND -filename zcl_abapgit_filename_logic=>c_package_file. -match = abap_false. -lstate = zif_abapgit_definitions=>c_state-deleted. -rstate = zif_abapgit_definitions=>c_state-unchanged....
And also the `packmove` flag seems to be not strict enough - it is set only for the case files are similar, but it's wrong. Or can be set for...
checksum and status calculation logic should probably be written somewhere in words. Or heavily commented. It's very difficult to judge (or remember ;) why this or that was done in...
Yes, I know. My point is that it does not work accurate for offline repos at the moment. But I'll have a look on it.