Alexander Tsybulsky
Alexander Tsybulsky
I've been thinking about the approach but nothing really automatic comes to mind. The only idea is: - define page names as constants in pages itself - then register current...
Mmm. I'd strongly disagree. I remember the time when it was in pages and the maintence of similar calls was much more difficult and error prone. It would just add...
> the router would become a god class I'd say it is just a big controller. Focusing on one function - creating pages. Most of cases are 2 lines to...
2 more issues: - checkbox is small, it will make the UX worse. This should be a custom control in such case. Large and convenient - it will not be...
checkboxes: yes exactly - they are small :) I'd think in the direction of a custom control. Or leaving the texts (better) just shortening them: "add/rm". Or some kind of...
it can be commit or private repo. I guess strategy A would be better. Better UX + native SAP memory for field history (if several users). But completely without dynpros...
Guess the identity-instance factory would fit somewhere in `zcl_abapgit_environment`, it also knows about GUI presence so would not need `set` (for now :). `zcl_abapgit_login_manager` should be quite independent - it...
Looks nice. A couple of thoughts: 1) probably would be nice to indicate the repo in the title and the operation performed - which is the context for giving the...
- renaming: agree, done - UI flag: I'm sure it will be very useful. I have some ideas how to improve current repo listing, will PR with time. My current...
imho: it goes closer to package management (#217). I'd suggest leaving this risk on a user for now. What will happen if I install 2 mirrors now ? I guess...