Sam Clegg
Sam Clegg
Do you need to run the tests? If not then presumably `-DBUILD_TESTS=OFF` in your cmake command should work around it for now?
> Previously I have been able to test end user setup by leaving out installing the dev dependencies. I designed this change specifically with your workflow in mind. IIRC the...
I re-titled, and updated the description to be a little bit more explicit about the intent here.
Anther potential upside here is that we add new test dependencies without effecting the distributed version of emscripten, or introducing new dependencies for our users. For example, we could starting...
> I suppose the question I have is - how do we test and verify that this will remain to be the case? Since it is not possible to run...
I added some assertion to emcc.py to ensure that the compiler itself doesn't run with those python libs in its path.
> What I worry is that not all tests start with invoking production `emcc`. The majority of test checks are run on the test Python side, and not via launching...
> It is beneficial to do this testing without dev dependencies installed. That ensures that the tested Python setup matches the production one. Its seems like we already have hard...
> 5\. if tests pass, zip up the emsdk directory as the Emscripten SDK artifact to Unity users. I think you certainly want to remove the `out/` directory before creating...
> Both pywin32 and psutil are production dependencies as per https://github.com/emscripten-core/emsdk/blob/7b4e60e4bfcba326025e373024369eaa9904af55/scripts/update_python.py#L77-L78 . But on linux we won't have python package in emsdk. How does it work on linux? I guess...