Sam Clegg
Sam Clegg
Oh I see... that is arguably a (different) bug. Maybe it doesn't make sense for us to set HOST_CC in that way... for example on windows it could be that...
What happens if we simply don't set HOST_CC at all? Will it get auto-detected?
> I say half way because to be truly fixed the solution shouldn't rely on wasm type reflection. Why do you say this? Is that simply because wasm type reflection...
> @sbc100 do you have any specific feedback on this PR? It feel like a lot of complexity to be adding. Perhaps we can find way to reduce it somehow?...
> @sbc100 this is ready for another round of review When discussing this change with @kripken he suggested that we could use an alternative approach which used a little extra...
> When I tried that approach previously I found the performance was unsatisfactory. But there is a decent chance that v8 has improved its stack switching machinery since then. I'll...
@zherczeg, have you run into this in any of your recent wasm-3.0 work on wabt? Is it part of one of you in-flight PRs maybe?
Is `(module instance ...)` the default behaviour? i.e. if you don't specify either `instance` or `definition`?
@sjamesr have you verified this fix works for your external use case? If so then landing this now (even though we don't need to locally) does not seem unreasonable.
Could you perhaps update the PR description mentioning why this is useful to you even though wabt itself doesn't currently use this?