Tam Mach

I don't think full CI is required, as Ingress related codepath are not covered by jenkins tests. As long as IngressConformance is successful, we can merge this PR. https://github.com/cilium/cilium/runs/7760353023?check_suite_focus=true

/test Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show. ### Test Name ```test-name K8sVerifier Runs the kernel verifier against Cilium's BPF datapath ``` ### Failure Output ```failure-output FAIL: Failed to load BPF...

:wave: I overlooked the commit message as well, I think it's still fine, as we have the history of conversation in this PR.

Once #5 is tackled, we can do this one. As suggesttion changes based on my understanding is just comment with ```suggestion ``` block

Just a note on this that not all linters are giving `suggestion` to correct error.

The above run seems not available now. I have created one dummy run to check [here](https://github.com/sayboras/golangci-lint/pull/230/checks?check_run_id=1303407789). The output is as per expectation. ```shell script run golangci-lint Running [/home/runner/golangci-lint-1.31.0-linux-amd64/golangci-lint run --out-format=github-actions]...

@dprotaso Thanks for your clarification. As golangci-lint is showing file name + line number, I transfered this issue to golangci-lint-action repo. ``` $ golangci-lint run ./... pkg/golinters/unparam.go:7: File is not...

@steebchen without going much to details, but I think you can just simply run `go generate` as part of github action job before running `golangci-lint-action`. If I am not wrong,...

> I've see a few tens of thousands of lines just filled with those errors since it logs one line per file > So I would personally classify this more...

hi, what I mean is just fresh clone + go build directly. Thinking about this, I feel like I might have pre-mature assumption, sorry about this. Let me try with...