golangci-lint-action icon indicating copy to clipboard operation
golangci-lint-action copied to clipboard

Published 20 hours ago • verified publisher icon golangci

Ability to make suggested changes on a PR

Open szunami opened this issue 4 years ago • 3 comments

Really appreciating this action, and it's ability to annotate PRs.

For many of the lint / vet rules, I think there are somewhat straightforward fixes. It would be awesome if this action could make suggested changes when possible (https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/incorporating-feedback-in-your-pull-request). Is this at all feasible?

szunami avatar Jul 10 '20 17:07 szunami

Once #5 is tackled, we can do this one. As suggesttion changes based on my understanding is just comment with suggestion block

sayboras avatar Jul 10 '20 23:07 sayboras

Just a note on this that not all linters are giving suggestion to correct error.

sayboras avatar Jul 12 '20 12:07 sayboras

That makes sense.

I think the suggestion UX is such a paradigm shift that could really improve adoption of linters, and would love to see those that don't currently support it think about what they could do (understanding that there are technical limitations). Thanks for the response, I might have some time to contribute in the near future. Please keep me posted!

szunami avatar Jul 12 '20 15:07 szunami