Tam Mach
Tam Mach
@georgysavva not sure if I missed something, I tried to run golangci-lint with your repo, seems fine ```console $ golangci-lint run -v INFO [config_reader] Config search paths: [./ /home/tammach/go/src/github.com/georgysavva/news-app /home/tammach/go/src/github.com/georgysavva...
I just take a look, please re-try after toggling check-exported param in config. I didn't check unparam code, as behavior is consistent with `check-exported` value. ```diff diff --git a/.golangci.yml b/.golangci.yml...
This might be the gap based on the fact that I didn't check code for unpram, will give it another crack next week.
Hi, sorry I am a little bit occupied at work recently, let me un-assign myself from this github issue, so that others can jump in and help.
Unassigned myself due to lack of cycles.
> Anything else still needed? Basically, the upstream chart offers some other the components that might not be related to Cilium, we only need barebone spire server and spire agent....
> Looks like its running as a sidecar to the server? We support extraContainers specified on the server, so I think that would work for loading the init script. IIRC,...
Thanks for your interest working on this issue, the current CI should provide enough coverage IMO.
> Cillium chart has [kubeVersion: ">= 1.16.0-0"](https://github.com/cilium/cilium/blob/main/install/kubernetes/cilium/Chart.yaml#L7C1-L7C27) requirements. I don't think it's the blocker. The reason of having 1.16 in chart.yaml is just to run old CI jobs.
Historically, we need to keep it with 1.16 for old CI jobs, however, we actually bump the k8s versions in CI recently. I need to check if there is any...