André Cruz

Results 161 comments of André Cruz

Hello @julien-f, if I understood correctly, the precision can vary when locking different paths that are associated with different file systems, is that correct? In those situations, Object.defineProperty can throw...

Didn’t know about the device. It seems we can indeed use that. Are you open to do a PR?

It looks good so far however one test is failing, can you check it out? We are missing tests as well before merging.

Yes we need to update existing tests and generate new ones to test the new code (different devices).

Understood the feature request. It would make more sense for the `lock` method to return the `release` function as well as how the lock was obtained (standard, reclaimed). However, that...

I agree. Can you change to not throw? This will have to be a major though because it’s a breaking change.

@pimlie I would prefer to not add any option and actually make this the default. This means that the PR would be much simpler by just changing this to not...

If the lock has been compromised, it usually means that someone else got the lock. It would be bad to delete the lock in that situation.

Hello! That’s because we try to resolve the real path of the file. You may disable the realpath option to disable this behavior.

Oh I misunderstood the question. At the moment, the path to the file must exist. Perhaps we could create the directory first with the `mkdirp` package, perhaps under and option....