André Cruz

Results 161 comments of André Cruz

See: https://github.com/yiminghe/dom-align

Hey @bcoe! You may find what issues `cross-spawn` solves here: https://github.com/moxystudio/node-cross-spawn#why Also, we explain why `options.shell` is not an alternative: https://github.com/moxystudio/node-cross-spawn#using-optionsshell-as-an-alternative-to-cross-spawn

@bcoe I might be wrong, but the `PATHEXT` is still an issue. Do you have any link/references?

The issue was closed by this comment: https://github.com/nodejs/node-v0.x-archive/issues/2318#issuecomment-264476003. If you go through the comments history, the only suggestion people gave was to use `options.shell` true but it's not really a...

> > I just realized that I should probably check if the object was really created by a custom constructor before using createObject if shouldCloneInstances is true. Yep. > >...

when using amd-utils, I find myself naming it utils: ``` js var utils = require('amd-utils'); ``` Having this in mind, I also prefer mutils. Let met think a bit and...

@millermedeiros agree. The solution I presented above work on instances but it's not optimal. Could the clone function accept a second argument, that if present, would be called for custom...

Two possible solutions: ``` js clone(some, true|false); // if true, would clone instances as well (defaults to false) clone(some, function (customType) { if (isObject(customType) && customType.constructor !== Object) { return...

@conradz Indeed. I don't like underscore behavior. I easily spotted that amd-utils was not cloning instances like I expected because of the missing properties. With underscore, it would cause deep...

Agree, but I think that having 2 separate packages for dealing with dates (date & time) could be confusing.