node-proper-lockfile icon indicating copy to clipboard operation
node-proper-lockfile copied to clipboard

Published 20 hours ago • verified publisher icon moxystudio

feat: cache precision per device

Open julien-f opened this issue 4 years ago • 3 comments

See #103

Quick and untested implementation.

julien-f avatar May 10 '21 06:05 julien-f

It looks good so far however one test is failing, can you check it out?

We are missing tests as well before merging.

satazor avatar May 10 '21 19:05 satazor

@satazor AFAU, the problem comes from the test expecting a specific number of calls to stat: https://github.com/moxystudio/node-proper-lockfile/blob/9f8c303c91998e8404a911dc11c54029812bca69/test/lock.test.js#L193

But the new algorithm, introduce an extra to get the device.

julien-f avatar May 10 '21 21:05 julien-f

Yes we need to update existing tests and generate new ones to test the new code (different devices).

satazor avatar May 16 '21 15:05 satazor