André Cruz

Results 161 comments of André Cruz

Reminder: add `babelrc: false,` to `babel-loader`'s options

I think @antoniocapelo might have more information

Here's a video demonstrating the problem for reference: https://drive.google.com/open?id=110ThoMGiqvY35yGzJ3FXNSVWf_KpnDb1

This is a very low priority issue for us. If you are willing to make it work with koa as well, I will review the PR and merge it.

@ilyaagarkov I've never tried using a default export actually. Could you instead export a `render` function to see if it's available? (sorry or the late response)

@arthens Correct, I will leave this open as a reminder to make this clear in the README

I guess that’s because ? has a special meaning in the url. It’s being interpreted as a query string.

Now that #30 added react v16 we now have [componentDidCatch](https://reactjs.org/blog/2017/07/26/error-handling-in-react-16.html). We should now re-evaluate this.

One huge disadvantage of using streaming is that we no longer have proper 500 status codes. If react fails during the streaming, we can no longer set the status because...

PR: https://github.com/karify/external-svg-sprite-loader/pull/47