Sascha Grunert comments

Results 1352 comments of


                                            Sascha Grunert

switch conmon-rs.spec.rpkg to conmon-rs.spec

@lsm5 thank you for the report. Do you consider to work on this as well?

build(deps): bump tokio-util from 0.7.10 to 0.7.11

@dependabot rebase

build(deps): bump tokio-util from 0.7.10 to 0.7.11

/lgtm

Journald Logger

@wasup-yash may I ask you to rebase this one?

Journald Logger

@wasup-yash do you want to give this one a rebase on top of `main`?

Finalize podman support in conmon-rs

Hey @validsudoku. I think a good starting point would be to understand how podman uses conmon: https://github.com/containers/podman/blob/295dd262/libpod/oci_conmon_common.go#L51-L68 in comparison to CRI-O: https://github.com/cri-o/cri-o/blob/2fc918d4b/internal/config/conmonmgr/conmonmgr.go#L19-L23 While we have an almost full feature set...

Add automatic shutdown after inactivity

> Is there a reason we open a new connection for each RPC call? If not, the solution would be open a connection in the `ConmonClient` constructor and always use...

Go Client: client.AttachConfig has ExecSession field but no way to get it

Hey @futurist, thank you for the question! You can leave the exec session empty for now since it's only a placeholder for a future feature we have in mind. :slightly_smiling_face:

`[sig-cli] Kubectl client Simple pod should support inline execution and attach` flakes

I spent some days looking into this and run out of ideas how to solve it. Therefore I would appreciate another pair of eyes.

Idea: Would it be possible to create the cgroup in advance?

Hey @utam0k, thank you for reaching out! I'm wondering if cgroup creation should be really a concern of conmon-rs, on the other hand we're also thinking about moving parts of...