Sascha Grunert

icon indicating a website link http://saschagrunert.de icon indicating an email [email protected]

icon company Red Hat icon location I’m on earth right now. icon location The difference between fine and great software is listening to people.

Results 821 comments of Sascha Grunert

server: remove exit file in exit monitor

/retest

server: remove exit file in exit monitor

A friendly reminder that this PR had no activity for 30 days.

build(deps): bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0

/lgtm

Multi storage support and selection using the runtime class

> or is it the function [`PodIDForName`](https://github.com/cri-o/cri-o/blob/main/internal/lib/container_server.go#L530) the right one to retrieve this information Yeah this should return the ID.

Multi storage support and selection using the runtime class

Had a discussion with @alicefr on slack about the previous two comments. :)

Multi storage support and selection using the runtime class

> @saschagrunert I've implemented a couple of functional tests. However, I need to use the `--with-pull` option (like [here](https://github.com/alicefr/cri-o/blob/multi-storage/test/multi_storage.bats#L71)) because the images are not prepulled for the additional storage. Is...

Multi storage support and selection using the runtime class

I'll revisit this PR later this week. :+1:

Multi storage support and selection using the runtime class

/retest-required

Multi storage support and selection using the runtime class

Looks like there are still some issues left open: https://github.com/cri-o/cri-o/runs/7088306948?check_suite_focus=true

Multi storage support and selection using the runtime class

> > Looks like there are still some issues left open: https://github.com/cri-o/cri-o/runs/7088306948?check_suite_focus=true > > Yes, I missed one `errors.Wrap` in the unit tests. Hopefully, now the unit and lint are...