conmon-rs
conmon-rs copied to clipboard
Journald Logger
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is to implement additional log driver support for the Journald which enables the container logs written to the systemd journal.
Which issue(s) this PR fixes:
part of #1126
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?
Added journald container logger support.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: wasup-yash Once this PR has been reviewed and has the lgtm label, please assign haircommander for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
@wasup-yash may I ask you to rebase this one?
@wasup-yash may I ask you to rebase this one
yes surely
@wasup-yash do you want to give this one a rebase on top of main
?
Codecov Report
Merging #1800 (c4e56d7) into main (4e0f474) will decrease coverage by
0.28%
. Report is 119 commits behind head on main. The diff coverage is43.37%
.
Additional details and impacted files
@@ Coverage Diff @@
## main #1800 +/- ##
==========================================
- Coverage 37.53% 37.26% -0.28%
==========================================
Files 15 17 +2
Lines 1268 1355 +87
Branches 414 435 +21
==========================================
+ Hits 476 505 +29
- Misses 526 568 +42
- Partials 266 282 +16