Sascha Grunert

Results 1311 comments of Sascha Grunert

@kubernetes-sigs/cri-tools-maintainers PTAL

Rebased to fix the CI.

@pohly good points! So the plugin comment should mention that: - SIG Release approval is required first (by interacting with the PR) - Approval from the corresponding SIG is required...

I guess hook needs to get updated which wasn't the case in https://github.com/kubernetes/test-infra/pull/36014. Let me investigate.

I guess we need to get this in https://github.com/kubernetes/k8s.io/pull/8744

Thank you for the report @olyazavr! This feels like a valid issue, even when it's a corner case. Unfortunately we'll have a hard time to fix this if we cannot...

I think this change would be fine, do you mind undrafting the PR so that we can run CI for it?