Sarah Dayan

Results 78 comments of Sarah Dayan

>I'm still not sure it's entirely necessary for `toSnapshot` or `toUnits`, makes the most sense for `toDecimal`. I dislike the idea of having inconsistent APIs for three functions that serve...

@johnhooks I removed the `transformer` fro `toSnapshot` and left it for `toUnits` and `toDecimal`. All tests for `transformScale` are added. We should be good now, wdyt?

@johnhooks I fixed the missed `toFormat` references, thanks for catching them!

@johnhooks That works for me, and makes the build slightly smaller by not setting default values. Check [2bf6376](https://github.com/dinerojs/dinero.js/pull/309/commits/2bf6376ddbac503865217c9fbcc4069e2da12274) and let me know what you think :)

`toFormat` was removed in [`v2.0.0-alpha.11`](https://github.com/dinerojs/dinero.js/releases/tag/v2.0.0-alpha.11) in favor of [`toDecimal`](https://v2.dinerojs.com/docs/api/formatting/to-decimal) which supports a generic output.

@FabienMotte We're in the process of moving `algolia/react-instantsearch` to our InstantSearch monorepo. This PR won't be transferrable, so I'll close it here, but please feel free to reopen it in...

Hey! We're doing a round of clean up before migrating this repository to the new [InstantSearch monorepo](https://github.com/algolia/instantsearch.js). This issue seems not to have generated much activity lately and to be...

@ShaMan123 We're in the process of moving `algolia/react-instantsearch` to our InstantSearch monorepo. This PR won't be transferrable, so I'll close it here, but please feel free to reopen it once...

@afgoulart We're in the process of moving `algolia/react-instantsearch` to our InstantSearch monorepo. This PR won't be transferrable, so I'll close it here, but please feel free to reopen it in...

Moving this into a Discussion since this is a feature request and not a bug.