react-instantsearch icon indicating copy to clipboard operation
react-instantsearch copied to clipboard

fix(createBoundingBoxFromHits): include check in the hit property "_geoloc"

Open afgoulart opened this issue 4 years ago • 5 comments

fix createBoundingBoxFromHits i included a check in the createBoundingBoxFromHits function when lists hits has one his or many hits with property "_geoloc" as array.

Summary

Result

afgoulart avatar Apr 27 '20 12:04 afgoulart

Deploy preview for react-instantsearch ready!

Built with commit 065208c1d75d794706faee7c5a3aef4d6e380322

https://deploy-preview-2920--react-instantsearch.netlify.app

algobot avatar Apr 27 '20 14:04 algobot

image

afgoulart avatar Apr 27 '20 14:04 afgoulart

it's expected that e2e tests don't run here, since you're an external contributor, and otherwise that api key would leak

Haroenv avatar Apr 27 '20 15:04 Haroenv

Hey @afgoulart do you think you could write a new test case like the ones here:

https://github.com/algolia/react-instantsearch/blob/065208c1d75d794706faee7c5a3aef4d6e380322/packages/react-instantsearch-dom-maps/src/tests/Provider.js#L47

It would be the same as the existing ones, except with an array in geoloc, or a an array in one and a single in another element

Thanks!

Haroenv avatar May 07 '20 12:05 Haroenv

would love this to be merged :)

SavageWilliam avatar Nov 18 '20 11:11 SavageWilliam

@afgoulart We're in the process of moving algolia/react-instantsearch to our InstantSearch monorepo. This PR won't be transferrable, so I'll close it here, but please feel free to reopen it in algolia/instantsearch.js.

sarahdayan avatar Dec 22 '22 15:12 sarahdayan