Sarah Dayan

Results 66 comments of Sarah Dayan

Nice one! Here are a few thoughts: - For discoverability, I'd show the refinements by default. Users can still hide it and you can save that as a preference, but...

I'd love to help with that, but I'm also interested in your feedback on the migration process! This is helpful to improve the [migration guide](https://v2.dinerojs.com/docs/getting-started/upgrade-guide) based on real world experience....

Cool! I will push another PR to allow for `transformScale` to take a rounding strategy since for now it won't be available anymore in `toUnits`. Both features will be in...

@jeremyckahn Hey! I didn't yet ship the PR in this release unfortunately (needed to release a few bug fixes, and I want to test the PR some more). Y can...

@jeremyckahn What issues did you run into?

I don't know if you got a chance to look into the [upgrade guide](https://v2.dinerojs.com/docs/getting-started/upgrade-guide) but contrary to v1.x where `toFormat` was coupled to the Internationalization API, v2.x lets you format...

This seems to be a Chrome behavior, Firefox scrolls differently: https://user-images.githubusercontent.com/5370675/191471876-7e191e72-2c5c-41f3-9f55-bd6459115bf5.mov Could the [`scroll-margin-top` CSS property](https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-margin-top) help here? That could be implemented in DocSearch (cc @shortcuts).

It does look like a bug. The problem persists in 1.5.0 so it doesn't look like a regression introduced in 1.5.1. I will investigate.

I've looked into it, this is indeed a bug. Here's what happens: - When calling `setIsOpen(true)`, the next state is computed with `isOpen=true`, which opens the search modal. - When...

@Haroenv The DocSearch example uses `autocomplete-core` and fully controls the UI. In this case, `autocomplete-js` is at fault and isn't user-controlled, so I'm afraid this can't be circumvented that way....