Stefan Appelhoff

Results 644 comments of Stefan Appelhoff

@emdupre I have completed my review. All issues that I raised have been addressed to my full satisfaction. I believe that `spectral_connectivity` is a valuable package that will serve the...

to be clear, this is not a requirement whatsoever, just a question / recommendation.

Hi, thanks for the report! PyPREP is a port of PREP in MATLAB (https://github.com/VisLab/EEG-Clean-Tools), and I believe the way we calculate the window size has been taken directly from the...

I think that's a classic case of "it was complicated and we only implemented what users needed at that time". I am afraid this will need a deep dive into...

Yes, an example that does that plus an introductory description of what you said in the beginning of your post would be nice. for all the people who want to...

migrating to 1.9.0 milestone because apparently this needs more discussion.

There are some more rules in this file: https://github.com/bids-standard/bids-specification/blob/d0d04a1deb7adcd2552f19ff9539cd11046a02a2/src/schema/rules/entities.yaml#L1-L3 > We are currently unsure what the best position for the _tracksys- key-value pair in the file name is yeah, good...

> Any opinions? The main danger we're running here is BST starting to do too many things. I kind of liked the notion that it's just a simple python library...

Haha, what a nice story -- looking forward to your new contributions!