Stefan Appelhoff

Results 644 comments of Stefan Appelhoff

I agree with Chris, but it would still be interesting to know which change lead to this and whether that was intended

@yarikoptic with Dora and Chris you have 2 +1s :-) given that Chris is pushing the derivatives branch now, it's probably better to furnish the PR sooner than later.

mhhh this is certainly a bug, and indeed one I encountered before (and I thought that I fixed it) ... so it's perhaps a regression. I don't know why this...

What's interesting is that the `eeg_matchingpennies` example also makes use of the Inheritance Principle with the EEG JSON sidecar file, see: https://github.com/bids-standard/bids-examples/tree/master/eeg_matchingpennies And this dataset passes the test :thinking:

> I'm thinking that maybe quick test should be rewritten to just look at directory structure +1 @rwblair ... apparently that quick test is back from BIDS 1.0, when there...

What @rwblair said in https://github.com/bids-standard/bids-validator/issues/830#issuecomment-649869429 is on point. this is also related to https://github.com/bids-standard/bids-validator/issues/792 --> both could be solved in one go and it looks like a reasonably simple job,...

> I don't remember whether the BIDS standard requires subject folders be called 'sub-X', if so, it would be easy to only search folders matching that pattern. it does, but...

okay, sounds reasonable to me, ignoring derivatives by default ... and if someone is really keen on getting matches there, they can pass the derivatives directory as the root.

@kaare-mikkelsen do you want to make a PR for this?

I think the idea of bids-examples so far was to provide self-contained, small examples that showcase specific ideas, rather than having huge monolithic examples. If you want a BIDS dataset...