Santiago Soler

Results 142 comments of Santiago Soler

You're right, it would be very complicated to remove `**kwargs` everywhere. I don't think we should tackle this all at once. But I think we should still discuss this topic...

> @santisoler Just be aware that you need to keep in mind that we don't just use linear inheritance as in your example. Many of the simulation classes have diamond...

> For each base class that has `object` as a parent, we could add a call that checks if the call to `super()` will call object, and return a better...

@jcapriot I think this is ready to be reviewed. Would you mind taking a look at it? Most of the changes are just removing deprecated stuff. But I also had...

Thanks @jcapriot for the early review. I started to apply the changes you mentioned and to extend them to other parts of this PR. Basically I restored every (hopefully) method,...

This PR got too big, it's super hard to review it and navigate through it. I'll split it in different PRs so we can start applying these changes one step...

Hi @deobald! Thanks for showing our appreciation for this repo. I agree that Creative Commons is not currently offering a proper alternative to the things we have in this repo,...

I agree too! It's annoying to having to handle the padding/unpadding steps every time we need to use these transformation functions. Regarding the choice of `xr.DataArray.pad()` and `xrft.pad()`. They both...

> Heh, I wish I had had thought up that idea -- it's a good one! But I think you might mean @mdtanker ? haha sorry! I just edited it....

This failing test might be related to how the random states are set across the test suite. Check this out for reference: https://github.com/simpeg/simpeg/issues/1289