Santiago Soler

Results 270 comments of Santiago Soler

Thanks for opening this issue @thibaut-kobold! I think it's fine if we wait for #1321 to be merged to add a minimal example that reproduce the error (kernel shutdown) you...

I've wrote a minimal example that (I suspect) reproduces the error that @thibaut-kobold was facing: ```python # file: eq_sources.py import numpy as np import SimPEG from SimPEG.potential_fields import gravity import...

I put more thoughts into this and I think the solution to this issue is not very trivial. What's going on is that the equivalent source class takes a 2d...

@lheagy, I've just pushed some tests for the DC simulations, plus one test for the SIP simulation. The DC tests are all passing, and they fail if we run them...

I've just reviewed @lheagy's PR (#1361) and I think we should go forward with that, but nonetheless I wanted to leave my two cents in this discussion. The proposed fix...

You're right that checksums might lead to collisions, but the sha256 hashes of two different arrays have a collision probability of $\simeq 1 / 2^{256}$, which is **extremely** low. In...

Thanks for sharing those thoughts @jcapriot. Just some personal opinions and preferences after reading them: ## Have clear scopes for the model attribute I think we should be super explicit...

Hi @xiaolongw1223! Thanks a lot for opening this PR and sorry for the delayed reply. I'll take a look a the example and leave a review. I think @dccowan would...

> Sorry for the messy commit history. Pycharm went a bit nuts on the imports. No worries! We can [Squash and Merge](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/about-pull-request-merges#squash-and-merge-your-commits) and clean it up later. I see a...

> Hi @santisoler , yes let me fix those. I can ping you when I am done with it. Errors are mostly related to examples using deprecated arguments, which I...