Santiago Soler

Results 219 comments of Santiago Soler

I agree that if we want to avoid allocating large coordinate arrays it doesn't make sense to generate huge `extra_coords` arrays with constant values. But it doesn't make any sense...

@leouieda What would be a good way to test this function? We were discussing this in the last meeting and we think a good idea would be to have sample...

That would be great @Esteban82! We would need small grids so they don't take too much space. Something around 50x50 elements would be good. Nevertheless, it would be nice if...

Awesome @LL-Geo! So, I would also want to support compressed grids. From what I read in [GRD File specification sheet](https://help.seequent.com/Oasis-montaj/9.9/en/Content/ss/glossary/grid_file_format__grd.htm) Oasis Montaj uses one of two compression algorithms: zlib and...

This is amazing @LL-Geo! Those hexdumps look so hacky! 😎 I was afraid that the default compression was the LZRW1,so sad. I wouldn't support that kind of compression in this...

@LL-Geo today I wrote some tests for this function using the grids you uploaded. Thank you very much! I think we don't have a grid with ordering = -1. Is...

Thanks for opening this issue @aguspesce. For the record, you are talking about this line: https://github.com/fatiando/harmonica/blob/d7c43540199a787246557afb8a20e071569c0f48/harmonica/tests/test_prism_layer.py#L96 The `reference` variable is defined in line 82: https://github.com/fatiando/harmonica/blob/d7c43540199a787246557afb8a20e071569c0f48/harmonica/tests/test_prism_layer.py#L82 And the `dummy_layer` is the...

I've noticed that SimPEG is not being tested by CI against newer versions of Python and was glad to find this Issue opened. I agree with @lheagy that we should...

You're right! The `interpolator.grid` method creates the xarray object, so grid coordinates can be 2D arrays obtained directly from `grid_coordinates`. Editing the issue description...

@leouieda Would you mind opening a new Issue for the new changes and closing this one. It might be better than editing this Issue to solve a different thing. I...