sanic

sanic copied to clipboard

**Describe the bug** A manual integration test of a Rasa HTTP API endpoint was failing with this traceback: ``` [1] [ERROR] Exception occurred while handling uri: 'http://rasa-worker:5005/model/train?force=true&save_to_default_model_directory=true&callback_url=http://rasa-x:5002/api/projects/default/models/jobs/7/result?token%3Drasaxtoken&token=rasatoken' Traceback (most recent...

ancalita

**Describe the bug** The `_app_registry` keeps hold of any app created by Sanic, even those stopped. **Code snippet** Adding the following code resolve the issue: ``` def stop(self): """ This...

cnicodeme

`Async for` can be used to iterate over a websocket's incoming messages

11

**Is your feature request related to a problem? Please describe.** When creating a websocket server I'd like to use `async for` to iterate over the incoming messages from a connection....

bradlangel

Allow RESPONSE_TIMEOUT to be disabled

6

**Is your feature request related to a problem? Please describe.** I would like to be able to disable RESPONSE_TIMEOUT so I can have long requests running until completion. **Describe the...

GabrielCappelli

Properly catch websocket CancelledError in websocket handler in Python 3.7

4

Apply fix #2463 to Sanic 21.12LTS version for python 3.7 users.

ashleysommer

Remove usage of ctx in routing

2

## TLDR Remove all Sanic reliance upon `ctx` values in the `routing` module. ## Rationale There are several locations throughout Sanic where the developer is provided with a `ctx` object...

ahopkins

A previous [PR](https://github.com/sanic-org/sanic/pull/2447) provides `cache-control` HTTP header to `file` function in Sanic, but the best practice is to also implement the etag and the file validator. **Correct me if I...

ChihweiLHBird

Streaming responses are not closed correctly on early exits (like a TERM)

10

While handling a request with a streaming response, the eof is sent in the finally block. This usually works well but when Sanic is TERMed or INTed, those streams are...

jmarcet

delete cookie doesn't support specifying the path.

5

**Describe the bug** Unable to delete a cookie set created with a non-default (`/`) path. **Code snippet** With this cookie ` response.cookie['token'] = "abcd" response.cookie['token']["path"] = "/api" ` the subsequent...

ruckc

Implement catchable WebsocketClosed

9

See #2220 In v21.9, a new `WebsocketClosed` exception was added. While you can to do the following: ```python @app.websocker("/") async def handler(request, ws): try: ... except asyncio.CancelledError: print("connection closed") ```...

ahopkins