sanic icon indicating copy to clipboard operation
sanic copied to clipboard

Properly catch websocket CancelledError in websocket handler in Python 3.7

Open ashleysommer opened this issue 2 years ago • 4 comments

Apply fix #2463 to Sanic 21.12LTS version for python 3.7 users.

ashleysommer avatar May 23 '22 23:05 ashleysommer

I'm guessing we don't need to worry about the linter checks failing on this?

ashleysommer avatar May 23 '22 23:05 ashleysommer

That's odd... I wonder why that is? I am assuming it must be a versioning issue. But yes, I do not care about that.

ahopkins avatar May 24 '22 05:05 ahopkins

Black check failing:

...
would reformat sanic/config.py
...
would reformat sanic/headers.py
...

Maybe a newer version of black used now than in December release? Or maybe some patches were pushed to 21.12LTS branch previously that broke formatting.

ashleysommer avatar May 25 '22 00:05 ashleysommer

I think it is a black version issue. I have run into this on some other projects.

ahopkins avatar May 25 '22 05:05 ahopkins