sanic

sanic copied to clipboard

Invalid request.url when full URI is used as SERVER_NAME

6

**Describe the bug** When using a full URL as `config.SERVER_NAME` the request’s URL (`request.url`) is invalid, as it contains two colons. The [code](https://github.com/sanic-org/sanic/blob/main/sanic/request.py#L715) does not properly split the `SERVER_NAME`, keeping...

PromyLOPh

event headers supplied as a generator, complicating asgi middleware

1

**Describe the bug** The headers exposed externally (perhaps to middleware) are a generator, which makes it challenging to intercept, inspect, or modify those headers without fully replacing the object. I...

aronatkins

distutils.strtobool deprecation

8

**Describe the bug** he distutils package is deprecated and slated for removal in Python 3.12. [PEP 632](https://www.python.org/dev/peps/pep-0632/) **Code snippet** [sanic/server/loop.py](https://github.com/sanic-org/sanic/blob/ac388d644b1e22156e228470fad8ea34932c080a/sanic/server/loop.py#L3) **Expected behavior** A lack of warnings about deprecation **Environment (please...

sjsadowski

Signals `http.middleware.before` and `http.middleware.after` are dispatched for _every_ middleware

9

For a single request, the signals `http.middleware.before` and `http.middleware.after` are dispatched for _every_ middle on the app. Example app: ```python3 from sanic import Sanic from sanic.response import html app =...

ashleysommer

Ability to check response from middleware signal handlers using modified context

9

It seems that the only way to return a value from a signal handler is to modify or add a value in context dict. That makes sense, because there might...

ashleysommer

Deprecate __blueprintname__

1

This code no longer seems like it is necessary: https://github.com/sanic-org/sanic/blob/5d683c6ea4b615e80c51d80189436437b824cce6/sanic/blueprints.py#L309 Since you can get access to the name of the blueprint from the request object, the route object, and the...

ahopkins

Graceful shutdown of signal handlers

5

When signals are added, we should run some sort of a cleanup like this on shutdown to make sure any custom signals are run. This also includes a suggestion that...

ahopkins

Uvicorn ignores listeners errors

2

**Describe the bug** When an exception happens on a listener the error is not reported and the server doesn't crash when using Uvicorn. **Code snippet** ```python from sanic import Sanic...

aericson

Manually triggered auto-reload

4

Hello fantastic community, I am using vault and consul to dynamically configure my sanic application. I am trying to find a way to make it so everytime the vault secret...

zikphil

Exception processing in tasks

2

**Is your feature request related to a problem? Please describe.** If someone adds logic into an exception handler for a purpose other than formatting the response, that will not be...

ahopkins