Kenichi Murahashi comments

Results 40 comments of


                                            Kenichi Murahashi

Add images

![saddler-pull-request-review-comment](https://cloud.githubusercontent.com/assets/75448/6392012/842ba6e2-bdff-11e4-84c3-bc180ac199bc.png) ![saddler-pull-request-comment](https://cloud.githubusercontent.com/assets/75448/6392013/892d1e5a-bdff-11e4-8ffb-f8ca93507662.png)

Example for Brakeman

Please try this.

Example for Brakeman

@m-kubo Awesome!!!!

Example for Rails Best Practices

Please try this.

should exit 1 if rubocop error raised

Thanks for your feedback 💃 In my understanding, it depends on the situation. `exit if none-zero` ? 🤔

Avoid building multi times

If I'm in travis-ci, check `TRAVIS_JOB_NUMBER` like this. ``` bash #!/bin/bash set -euv if [[ "${TRAVIS_JOB_NUMBER: -2}" == ".1" ]]; then # you want to do fi ``` OR ```...

Avoid building multi times

Need document.

guest

comment

Add example run locally

Need document.

vs. reviewdog

# Saddler ## pros - Support Jenkins GitHub pull request builder plugin - Easy to build reporter plugin - only me? ;( ## cons - Not easy install if you...