Kenichi Murahashi

Hello any update for this PR ? ping @jwilder

same error(?) with iojs v1.5.1 ``` text [error] "2015-03-18T20:45:35.696Z" 'error from lcovParse: ' 'Failed to parse string' [error] "2015-03-18T20:45:35.700Z" 'input: ' '' [error] "2015-03-18T20:45:35.701Z" 'error from convertLcovToCoveralls' /home/travis/build/sanemat/nwjs-nico-player/node_modules/coveralls/bin/coveralls.js:18 throw err;...

`"chromium-args": "--file-descriptor-limit=2000"` does not work on `nwjs-v0.12.2-osx-x64`. `$ nwjs target/ --file-descriptor-limit=2000` works well.

Thanks! I'll check it later! On Tue, Jan 21, 2020, 15:37 Federico Brigante wrote: > I recently published 2 modules that might help you with this: > > https://github.com/fregante/webext-domain-permission-toggle >...

You mean you want to use this extension as (web) application like travis-ci or coveralls? :thinking:

Good catch! I don't have an idea, yet. Chrome extension requires target url. https://github.com/sanemat/do-not-merge-wip-for-github/blob/df5fc2cb3b1912448ce7ff278b34c969fef3280b/app/manifest.json#L22-L24 ``` "matches": [ "https://github.com/*/*/pull/*" ], ``` `matches: ["*"]` is "overkill", I think.

I prefer a custom build like `npm run build -- --matches=https://example.com/* --matches=https://test.com/*`. This will append `matches` to `manifest.json`. ``` "matches": [ "https://github.com/*/*/pull/*", "https://example.com/*", "https://test.com/*" ], ``` This keeps `matches` simple...

Nice idea :cat:

@andreasohlund "reload page" is required now. It would be better for me if I get disabled button "without reload" :smile:

I have commented :smile_cat: