ruby-saddler icon indicating copy to clipboard operation
ruby-saddler copied to clipboard

should exit 1 if rubocop error raised

Open rnitta opened this issue 7 years ago • 1 comments

I'm using Rubocop with Saddler like this in Rails project on CircleCI hooked by Github push.

When there are Rubocop error with my code, CircleCI build ends with no errors (while warning comments are posted on PR). I think Saddler Reporter should exit 1 if there are something to post.

thoughts?

rnitta avatar Nov 01 '18 02:11 rnitta

Thanks for your feedback 💃

In my understanding, it depends on the situation. exit if none-zero ? 🤔

sanemat avatar Nov 01 '18 15:11 sanemat