Sam Wilson

Results 157 comments of Sam Wilson

It'd be great to have footnote support! There's a typo in the test filenames by the way, which is why the tests are passing. Note that there's a MarkdownExtra test...

This is ready for review again.

Where are you seeing it create those as absolute links? It seems to just use it verbatim: ```bash $ echo -e "[foo](#bar)\n\n##Bar" | ./bin/markdown --flavor=gfm foo Bar ``` But you're...

I don't think it's possible to remove the absolute link when parsing that. How would the parser know that the document is a Github readme? And you're right, it looks...

Why not just leave the URLs out of the Markdown though? I'm not sure I really understand the use case here. :-) I do think adding anchors is a good...

Hmm that does sound trickier!

I'll try to match whatever's existing, and go with PSR12 where it's not clear.

Oops, I only just noticed that it says in `CONTRIBUTING.md`: > I am following a code style that is basically PSR-2 but with TABS indentation (yes, I really do that...

Relatedly, there's some good info at [php-pds/skeleton](https://github.com/php-pds/skeleton) about common directory structures for PHP projects. They recommend `src/` and `tests/` among other things. I guess it mostly comes down to standardization,...