Sam Wilson

Oh sorry. I didn't think it was off-topic. I was trying to say that the addition of this context menu option for copying would be great. There used to be...

There's some discussion on #582 about whether this package is maintained, and if not which fork could perhaps be the successor. (I'm just another user of this and would also...

It does need a key, because it makes actual calls to Flickr. It used to be possible to have a test account, but a few years ago they started deleting...

Looks like that'd be fine? There's a bunch of places we could delete the `@return` and instead have return type hints.

Oh oops! Fixing in #82.

The API key should be in `tests/config.php` (and `examples/config.php` for those). I think returning null to indicate not cached is probably fine. We never want to cache a null.

Or you can set them as the env vars `FLICKR_API_KEY`, `FLICKR_API_SECRET`, `FLICKR_ACCESS_TOKEN`, `FLICKR_ACCESS_SECRET`.

This looks good, thanks! I think `getSets()` is supposed to be replaced at some point, but this is probably sensible in the meantime. c.f. #14

Will this break old links?

Can you share the code that results in this? Doing something like ```php $userAndPassword = new UserAndPassword( 'admin', 'pass123' ); $api = MediaWiki::newFromEndpoint('http://localhost/wiki/Foobar', $userAndPassword); ``` results in ClientException `Client error:...