Samuel Ainsworth

I attempted packaging via bdist_wheel but for some reason the test suite was failing (via pytest). I don't remember the exact details. I'll have to give it another shot and...

For some context `async`/`await` syntax has been supported in node.js since v7.6.0 which is from 2017, so we wouldn't be dropping support for barely anyone AFAICT.

I have completed a translation from `.then`-ing to async/await for the entire `lib/` and `lifecycleScripts/` directories. Commits are linked above. There are only a handful of `.then`s left in places...

@KyleTryon Seeing the same error with node v16.4.0, macOS 11.6, node-pre-gyp v0.13.0, node-gyp v4.0.0. You can see my full log [here](https://gist.github.com/samuela/529ba51c1f8c84e87a73f849e854604e). The interesting bit however is ``` In file included...

It's worth mentioning that building from source on the latest master (4561dcb7c120474a4553baa27e4c4c2f4be23a2b at the time of writing) does work for me. So perhaps this issue has been fixed. However attempting...

`npm i [email protected]` does work, so I think this issue can be closed once 0.28.0 is released!

Any word on when the next release will be cut?

Thanks @ianhattendorf! I can poke around a little bit, but I don't have much experience with npm/gyp. One thing that I have noticed is that I get a different error...

Looking at this a bit more: Why not just remove the isGitRepo check here: https://github.com/nodegit/nodegit/blob/4da92c9cba19a9a70bec498c13e8efa6199f56fa/lifecycleScripts/preinstall.js#L28-L35 Is there a reason to not run `submodules` and `generate` in some cases?

Ok, I tried fixing in https://github.com/samuela/nodegit/commit/b74a5911779482038845534bb1ddf3652bdaa33f. Now seeing a new error (full log [here](https://gist.github.com/samuela/88b5e60007f180489ffa10c1e47bb17d)): ``` 66 error Error: Cannot find module 'fs-extra' 66 error Require stack: 66 error - /Users/skainswo/.npm/_cacache/tmp/git-clone-1d65c3f9/generate/scripts/utils.js...