Sam Rabin

Results 134 issues of Sam Rabin

As Fang has updated some inputs, it'd be nice to move them to streams files rather than having to update them on all the surface datasets. - `peatf` (peatland fraction)...

enhancement

It's unsupported!

enhancement

# Work in progress! Do not review! ### Description of changes In the existing code, when using the default CLM crop calendars, `gddmaturity` (maturity requirement; the number of growing degree-days...

### Brief summary of bug In the branch for my latest crop calendars PR (#2593), the new aux_clm test `ERP_D_P128x1_Ld26.f10_f10_mg37.IHistClm60BgcCrop.derecho_intel.clm-midDecStart_clm-RxCropCalsAdaptGGCMI` fails `compare_base_modpes`. ### General bug information **CTSM version you are...

type: bug

- `peatf` (peatland fraction) - `abm` (agricultural fire peak month)

enhancement

### Description of changes - Improves peat burning dependence on climate - Improves dependence of deforestation burning on climate. - Allows lightning ignitions in tropical closed forest. (Human ignitions, other...

type: enhancement
tag: enh - new science

As discussed at [CSEG meeting 2024-06-18](https://docs.google.com/document/d/186U6-dt_wWZZGU9NzYQ5zNlMnpx9XX6oweuTXzQY-oo/edit#heading=h.gjot13e7ggkb), we want to reduce unnecessary log output in CESM, especially `cesm.log`. We should look through CTSM to see what we can do in this...

tag: bfb

At [SE meeting 2024-06-20](https://docs.google.com/document/d/1tgDRocjAFF1svWjt0mvjjPaPLFuDZEHLpf4vlGIQs5o/edit#heading=h.vuovfsr25o7y), we decided that long Python comments don't need to be wrapped. This rule change should be added to the file that controls `pylint`.

good first issue
testing
bfb

There are several places in the RXCROPMATURITY test code (`rxcropmaturity.py`) where a call is made to `subprocess`. E.g.: https://github.com/ESCOMP/CTSM/blob/a9433779f0ae499d60ad118d2ec331628f0eaaa8/cime_config/SystemTests/rxcropmaturity.py#L388-L409 https://github.com/ESCOMP/CTSM/blob/a9433779f0ae499d60ad118d2ec331628f0eaaa8/cime_config/SystemTests/systemtest_utils.py#L43-L54 It would be more robust to import the relevant functions...

type: code cleanup
type: tests

It's implicitly tested as part of the RXCROPMATURITYSKIPGEN run, but it would be safer to have Python unit and system testing for it.

priority: low
type: tests