Sam Rabin

Results 301 comments of Sam Rabin

Just realized it might also be useful to have another output variable that effectively does the "sum across `mxharvests`" step itself. I'll plan to add this in another commit; something...

Found some discrepancies between gridded/remapped results from GRAINC_TO_FOOD vs. GRAINC_TO_FOOD_PERHARV vs. GRAINC_TO_FOOD_ANN. Investigating…

Okay, in my test run, it looks like the new per-harvest and annual outputs are identical to within < 1 mgC/m2, which should be fine. But per-harvest differs from the...

Turns out it's all good; I just had forgotten to time-shift the daily outputs in my Python script. ``` Max diff, original vs. perharv: (150.0,-10.0) sugarcane (67) 2007: 0.000244140625 (1094.70556640625...

Commits above add more outputs, all with dimension `mxharvests` unless otherwise noted: - SDATES_PERHARV: actual sowing date (day of year) for crops harvested this year. - SYEARS_PERHARV: actual sowing year...

Closing, as everything in this PR should also be in #1863.

I'm not changing these variables' names or definitions in my work, so no worries there. Jyoti, let me know if my read is correct here: - I don't see anything...

@jyoti1singh: I still think the two mentions of $GDD_{min}$ are correct, although potentially confusing. But maybe I'm missing something. To help clarify, what do you think of what I wrote...

Re: $GDD_{min}$: Sure, the users can try to parameterize it based on the real-life distribution of the crop/cultivar. But it's also kind of a weird parameter, if you think about...

@danicalombardozzi sorry, meant to tag you above, and adding you in an edit isn't working. Sorry if this spawned multiple notifications.