Sam Gleske

Results 397 comments of Sam Gleske

This change can’t be merged or tested without passing checks.

We could merge this but we need a warning in the CHANGELOG before release. We also need to warn the update center about breaking changes which is exposed to admins...

If we merge it as-is, then we need to do two things before releasing. 1. Add a warning to the upgrade notes in the CHANGELOG describing the change in behavior....

If we merge it as-is, then we need to do two things before releasing. 1. Add a warning to the upgrade notes in the CHANGELOG describing the change in behavior....

If we merge it as-is, then we need to do two things before releasing. 1. Add a warning to the upgrade notes in the CHANGELOG describing the change in behavior....

@conf I can take a look. Looks like there's failing tests so I'll have to pull it down locally and try it out. I've got some family coming over tonight...

@conf I can't seem to wrangle checkstyle into working which would block release. Here's an example failure. ### mvn clean test package ``` $ mvn clean test package ... log...

I can take a look next week. Currently traveling on vacation and will take a look when back.