ghprb-plugin icon indicating copy to clipboard operation
ghprb-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jenkinsci

Feature: Option to report success to PR when build is not triggered

Open MaitreyaBuddha opened this issue 7 years ago • 17 comments

This is a resolution for https://github.com/jenkinsci/ghprb-plugin/issues/630

This introduces a new checkbox after include/exclude sections. It gives you the ability to report GHCommitState.SUCCESS status with "Skipped..." message when a build is skipped because it didn't match any include/exclude patterns.

For example, if you have 4 builds but only Java files changed, you might get this output: image

The title of this PR should work for CHANGELOG entry.

MaitreyaBuddha avatar Feb 21 '18 02:02 MaitreyaBuddha

@samrocketman I this is fine for you I would go ahead and merge this and test the current master with the other PRs which are "candidate to merge" and are approved by either me or you. Is this fine for you?

bjoernhaeuser avatar Apr 28 '18 12:04 bjoernhaeuser

@bjoernhaeuser you're welcome to go ahead; I haven't had a chance to look at it but if you feel it's good to merge I don't have any problem with it.

samrocketman avatar Apr 29 '18 07:04 samrocketman

Sorry for the noise, we prematurely merged unrelated work to our fork's master. It has been reverted and this is back to the latest relevant changes.

MaitreyaBuddha avatar May 01 '18 00:05 MaitreyaBuddha

@MaitreyaBuddha could you squash your commits into one? :)

bjoernhaeuser avatar May 10 '18 11:05 bjoernhaeuser

@bjoernhaeuser Done! Github also has an option to do that when merging if you have not disabled it in settings.

MaitreyaBuddha avatar May 11 '18 01:05 MaitreyaBuddha

@MaitreyaBuddha would be cool if you can rebase to latest master to retrigger the jenkins build itself. For whatever reason it failed :(

bjoernhaeuser avatar May 27 '18 17:05 bjoernhaeuser

@bjoernhaeuser Rebased and passed 💥

MaitreyaBuddha avatar May 31 '18 00:05 MaitreyaBuddha

We're planning to release this upcoming Monday and won't be merging any additional changes until after Monday's release (Apr 4th).

samrocketman avatar May 31 '18 07:05 samrocketman

Any update on this issue?

miguelslemos avatar Oct 25 '18 01:10 miguelslemos

This change can’t be merged or tested without passing checks.

samrocketman avatar Oct 26 '18 05:10 samrocketman

Rebased to master to trigger build again. Looks g2g?

MaitreyaBuddha avatar Nov 13 '18 20:11 MaitreyaBuddha

I'll look it over again.

samrocketman avatar Dec 07 '18 23:12 samrocketman

@samrocketman IMHO we can merge this :)

bjoernhaeuser avatar Jan 13 '19 11:01 bjoernhaeuser

I had to create another fork and PR to trigger build again: https://github.com/jenkinsci/ghprb-plugin/pull/739

MaitreyaBuddha avatar Mar 28 '19 21:03 MaitreyaBuddha

@samrocketman also with this, can we merge it?

bjoernhaeuser avatar May 26 '19 11:05 bjoernhaeuser

Can we merge this and release new version ?

mmpetarpeshev avatar Jul 22 '19 13:07 mmpetarpeshev

Any update on this one.

asif-anwar avatar Oct 07 '21 06:10 asif-anwar