ghprb-plugin
ghprb-plugin copied to clipboard
jenkinsci
Added an option to enforce code review approvals for auto merge
If "Merge only approved code" configuration option is activated the plugin verifies if there is at least one approval given. Otherwise the pull request will not be merged. This is deactivated by default.
This can be used to auto merge reviewed and approved pull requests only.
@bjoernhaeuser maybe have a look? thanks
@bjoernhaeuser The effect we are looking for is that the PRB will merge the PR if it was approved during build time. This will spare the reviewer from keeping an eye on the PRB until it is done in order to merge it asap. If the PRB did finish already before the review the reviewer can merge the PR anyway right after he approved it. Note that our PRB starts right after a PR is created and the PRB takes quite long. This change will enable us to configure this, right?
@bjoernhaeuser looks like you have to approve as well in order to be able to merge this. :/
@bjoernhaeuser @cedric05 guys please merge. We have more changes on the pipeline we want to contribute
@samrocketman Hey, sorry to bother you but maybe you find time to review this? @cedric05 and @bjoernhaeuser already had a look at it. Thanks for your effort
I can take a look next week. Currently traveling on vacation and will take a look when back.
@samrocketman yup, looks like 2021 could be my lucky year :) Please review again
I am very interested in this feature and like to get this merged and released. So, I am asking the remaining maintainers stated at https://plugins.jenkins.io/ghprb/ and that I am able to find, to take care of this pr please: @olivergondza @benpatterson
