Sami Jaber

Results 309 comments of Sami Jaber

@JLarky thanks for making the changes! unfortunately it looks like a few of our integration tests are now getting errors specifically around the expected image width. It's inconsistent: looks like...

Converting to draft given all the other changes needed (made a TODO list in the description to track them)

Thanks for the heads-up about the dependencies. We will test our SDK against Svelte 5, and make any adjustments necessary

Thanks for the contribution @nmerget! @sidmohanty11 jumped in and helped address some issues in the PR, hope that's okay 😄

`props.children` is indeed a special prop. You can only use it by rendering it like `{props.children}`. Many frameworks are unable to manipulate the prop and iterate on it. We should...

Go for it! You can add a note here: https://mitosis.builder.io/docs/components/#children https://github.com/BuilderIO/mitosis/blob/main/packages/docs/src/routes/docs/components/index.mdx#children

Looks like you have some issues with your Solid and Marko tests: ![CleanShot 2024-10-02 at 10 46 20@2x](https://github.com/user-attachments/assets/65a4090e-ca14-41ea-978c-44d3ee97b19a) ![CleanShot 2024-10-02 at 10 47 28@2x](https://github.com/user-attachments/assets/5e83b240-6bc1-46ee-a069-809ae5e694eb) when tests go from throwing to...

@nmerget very weird. I'm not sure why this is happening. I ran `yarn test:update` in `packages/core` on my end and it seems to have updated them on the first try.

@nmerget you'll have to setup commit verification moving forward by the way. We enabled it recently for the Mitosis repo.