mitosis icon indicating copy to clipboard operation
mitosis copied to clipboard

fix: issues for angular signals api

Open nmerget opened this issue 9 months ago • 2 comments

Description

Please provide the following information:

Minor fixes for Angular api=signals

Make sure to follow the PR preparation steps in CONTRIBUTING.md before submitting your PR:

  • [x] format the codebase: from the root, run yarn fmt:prettier.
  • [ ] update all snapshots (in core & CLI): from the root, run yarn test:update
  • [x] add Changeset entry: from the root, run yarn g:changeset and follow the CLI instructions. Alternatively, use the Changeset Github Bot to create the file.

nmerget avatar Apr 14 '25 08:04 nmerget

🦋 Changeset detected

Latest commit: 4733ae26a0994b228d948c853e49f6d116acb8d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Apr 14 '25 08:04 changeset-bot[bot]

View your CI Pipeline Execution ↗ for commit 4733ae26a0994b228d948c853e49f6d116acb8d5.

Command Status Duration Result
nx e2e @builder.io/e2e-app ✅ Succeeded 2m 5s View ↗
nx run-many --target test ✅ Succeeded 5m 10s View ↗
nx run-many --target build --exclude @builder.i... ✅ Succeeded 3m 47s View ↗
nx build @builder.io/mitosis-site ✅ Succeeded 2m 26s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-01 06:20:05 UTC

nx-cloud[bot] avatar Apr 14 '25 08:04 nx-cloud[bot]

@nmerget we meant to approve this but forgot to! if you can go ahead and update the snapshot tests one last time, it will be merged 🙏🏽

Done :) @samijaber

nmerget avatar Jun 26 '25 07:06 nmerget

@nmerget you'll have to setup commit verification moving forward by the way. We enabled it recently for the Mitosis repo.

samijaber avatar Jul 17 '25 15:07 samijaber