mitosis icon indicating copy to clipboard operation
mitosis copied to clipboard

Selector template

Open nmerget opened this issue 1 year ago • 3 comments

Description

Adds an explicit, selector option to override the default selector: '${kebabCase(json.name || 'my-component')}' with useMetadata for angular output.

Closes https://github.com/BuilderIO/mitosis/issues/1442 closes https://github.com/BuilderIO/mitosis/pull/1443

Also see: angular's style guide https://github.com/BuilderIO/mitosis/issues/747

nmerget avatar Aug 19 '24 06:08 nmerget

🦋 Changeset detected

Latest commit: 7255afe4fc3c88c8a42ae10af08f5eaeeb288e59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@builder.io/mitosis Patch
@builder.io/mitosis-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 19 '24 06:08 changeset-bot[bot]

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8531560 Triggered Generic High Entropy Secret 00b038dcacd708d660e2bebcddc47d68448ea0d1 nx.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

gitguardian[bot] avatar Aug 19 '24 06:08 gitguardian[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 7255afe4fc3c88c8a42ae10af08f5eaeeb288e59. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Aug 19 '24 06:08 nx-cloud[bot]

Thanks for the contribution @nmerget! @sidmohanty11 jumped in and helped address some issues in the PR, hope that's okay 😄

samijaber avatar Sep 03 '24 16:09 samijaber

Thanks for the contribution @nmerget! @sidmohanty11 jumped in and helped address some issues in the PR, hope that's okay 😄

Sure, thank you. There was this wired issue with the formatting, so I was blocked and then it was out of my mind ^.^

nmerget avatar Sep 04 '24 05:09 nmerget