Sameh Abouel-saad
Sameh Abouel-saad
Thank you @renauter for your review! I have either addressed or replied to your notes. Please review and let me know if you have any further comments.
``` [2024-08-25T23:16:53Z INFO pallet_smart_contract::migrations::v12] >>> Unused Smart Contract pallet V12 migration [2024-08-25T23:16:53Z INFO try-runtime::cli] PoV size (zstd-compressed compact proof): 579.5 KB. For parachains, it's your responsibility to verify that a...
> Before starting to distribute rewards (which funds should come from previously reserved amounts) I feel a lack of extra check similar to `ensure( account_reserved >= standard_rewards + additional_rewards)`. >...
One last change I switched from using `ValueQuery` to `OptionQuery` for the `ContractPaymentState`. It is more prone to error since it always returns a default value from storage. Although we...
@renauter Thank you so much for reviewing! It was really helpful.
> are these procedures still valid? If not we should make new ones and test The procedures for adding a new validator remain unchanged. However, the referenced documentation is inaccurate....
> Can we still use these snapshots if we apply the different pruning flags? No, they won't be compatible. This why I was recommend building two types of snapshots. one...
> does it make sense to only have a snapshot creator for mainnet in this case? As you already know, Snapshots are primarily used to speed up the process of...
**Update:** See the PR with the updated docs https://github.com/threefoldtech/tfchain/pull/1007
Thanks for the report! The issue is currently being investigated.