Sameh Abouel-saad

icon indicating a website link https://www.linkedin.com/in/sameh-farouk-software-developer/ icon indicating an email [email protected]

icon company I’m a learning machine icon location Egypt, Cairo icon location Self-led software engineer, specializing in blockchain and distributed systems, builds technologies shaping the Internet's future.

Results 110 comments of Sameh Abouel-saad

Error distributing cultivation rewards

Thank you Dylan for your feedback. Yes I noted that before and opened an issue here https://github.com/threefoldtech/tfchain/issues/969 regarding the misuse of the balance lock

Error distributing cultivation rewards

**Update:** The amount tracked in the contract lock during the grace period is incorrectly divergent from the lock on the user balance leading to illiquidity issues when it's time to...

Pallet KV: scale the fee with the amount of bytes stored

I would like to share my opinion on how this pallet stored data on chain. First of all, I think the basic rule for blockchain runtime storage is to keep...

The helm chart default values has ingress annotations

@robvanmieghem Can you add more context or explain what need to be done here?

Change `tftprice():u32` digit count

@A-Harby can you elaborate or include more context?

Change `tftprice():u32` digit count

okay we should look into this

Change `tftprice():u32` digit count

> TFchain is using a 3-digit representation with a TFT value First, Let me correct that assumption. TFChain `tokenDecimals` is configured in the chain spec of the chain as 7...

Devnet light public node issues after it being offline for a while

@coesensbert is this still relevant?

express-pino-logger dependency is deprecated

https://github.com/threefoldtech/tfchain/blob/c6cd4f3905eea2f9bf07a45b689b287245311ef1/activation-service/package.json#L26

refactor: Billing refactor

> Looks like this PR is quite big and contains many things. > > Is it possible to split the PR into smaller things? Smaller PR will make it easier...