tfchain icon indicating copy to clipboard operation
tfchain copied to clipboard

The helm chart default values has ingress annotations

Open robvanmieghem opened this issue 4 years ago • 2 comments

Since providing a custom values file merges with the default one and does not override, kubernetes.io/ingress.class: traefik is always present

robvanmieghem avatar Aug 18 '21 10:08 robvanmieghem

@robvanmieghem Can you add more context or explain what need to be done here?

sameh-farouk avatar Nov 06 '23 12:11 sameh-farouk

Looks like this issue is transferred from the tfchain_activation_service repo where the deafult values file of the helm chart had kubernetes.io/ingress.class: traefik in the ingress annotations. As I explained above,a custom values file merges with the default one and does not override so this the ingress class annotation can not be overidden. Currently the default values file has kubernetes.io/ingress.class: nginx set: https://github.com/threefoldtech/tfchain/blob/38ea78797ca2bb2c1ee27efa43b607c86b322e6c/activation-service/helm/tfchainactivationservice/values.yaml#L43 It's best to get rid of that, do mind that this needs to be communicated to the people using that chart since they will have to provide the annotation themselves if they need it.

robvanmieghem avatar Nov 06 '23 14:11 robvanmieghem