Sam Eiderman

Results 16 comments of Sam Eiderman

Coverage is being a bit hard to achieve, even with added tests

Hey! I don't agree with the statement that it *must* run as the same user. When we run our tests locally we are indeed enjoying the fact the test runs...

Things are not always this easy thought :-) We are building using earthly.dev and we pass GitHub credentials using an ssh agent integrating into the docker. i.e. `RUN --ssh go...

If someone wants a working code snippet for GitHub yaml: ``` - name: Run pulumi preview env: GITHUB_TOKEN: ${{ secrets.PULUMI_PAT }} working-directory: ${{ env.WORK_DIR }} shell: bash -e -o pipefail...

Hey, still haven't got to creating a whole new example protobuf. I see that some other PRs extending my work have also made their way there: https://github.com/grpc-ecosystem/grpc-gateway/pull/3240

Hey, Pitching in. BTW, buf links are not permanent (https://buf.build/grpc-ecosystem/grpc-gateway/file/main:protoc-gen-openapiv2/options/openapiv2.proto#L230) But if we meant this: https://github.com/grpc-ecosystem/grpc-gateway/blob/67896a82850755d6f6ddfa68e034d1e5b7d7512b/protoc-gen-openapiv2/options/openapiv2.proto#L280 Can't we change `Schema schema = 2` to `optional Schema schema = 2`? However...

In this case, this is a breaking change, but however I think it's fine since I guess no one is using those annotations outside of grpc-gateway Go generated files -...

Actually this is going too strong in the other direction. Default 200 responses are not auto generated for the 99 out of the 100 API's which are not `google.protobuf.Empty` (One...

Same as just `message AnotherEmpty {}`