Sal Ferrarello

Results 75 comments of Sal Ferrarello

Yeah, I feel like we've been supporting XHTML when we think of it but not making it a priority. I'm in favor of stripping XHTML from the theme and making...

I've turned this into an actionable item in #155

@bryanwillis As I look at the changes involved, I'm revisiting this question. I agree that we could change ``` $nav = genesis_markup( array( 'html5' => '', 'xhtml' => '', 'context'...

I'm still wrapping my head around this code but a couple of quick notes so I don't need to remember them for later. ## PHP Warning I'm getting the warning...

Looking at the Genesis code in `lib/functions/menu.php`, it looks like the filters `genesis_do_nav` and `genesis_do_subnav` are still in place for backwards compatibility. So instead it looks like we should be...

I believe the Bootstrap nav only supports a depth of 2. So, I think we should change this value from 3 to 2. ``` $args['depth'] = 3; ```

@bryanwillis Cool, thanks for sharing this.

With this code change I am seeing some differences in the output nav code. ## For Example ### Old Output ``` About ``` ### New Output ``` About ``` ##...

See branch `change-col-other-layouts-119` for proposed changes.

Ok, I've been reviewing my previous preposed changes, which looked like this for **sidebar-content-sidebar** ![screenshot 2016-04-07 11 39 29](https://cloud.githubusercontent.com/assets/5194588/14357119/7464004c-fcb5-11e5-8c1a-5c2b1254e5be.png) I think this is simply too narrow for the content column...